Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linter to redocly #64

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Update linter to redocly #64

merged 1 commit into from
Jan 27, 2023

Conversation

jimmygchen
Copy link
Contributor

@jimmygchen jimmygchen commented Jan 25, 2023 •
edited by ralexstokes
Loading

Fixes #63.

Replace spectral with redocly, for the same reasons as ethereum/beacon-APIs#223

We had some issues with the old linter in this PR, and @ralexstokes pointed out that we're using a different linter to the Beacon APIs.

@jimmygchen jimmygchen mentioned this pull request Jan 25, 2023
Merged
ralexstokes
ralexstokes reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! and thanks for doing this :)

I left some questions but think we should merge soon

.github/workflows/main.yml Show resolved Hide resolved
.redocly.yml Show resolved Hide resolved
@ralexstokes ralexstokes merged commit 540bcca into ethereum:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use redocli for CI linting
2 participants
@jimmygchen @ralexstokes