verify_cell_kzg_proof_batch(): Abstract commitment to interpolation poly
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtraglia
reviewed
Aug 16, 2024
jtraglia
reviewed
Aug 16, 2024
jtraglia
reviewed
Aug 16, 2024
b-wagn
reviewed
Aug 16, 2024
| ); | ||
|
|
||
| // Mark the cell as being used | ||
| is_cell_used[index] = true; |
There was a problem hiding this comment.
As this PR only moved this, this is a comment that probably should be addressed in a separate PR:
We set is_cell_used at indices which are not a multiple of FIELD_ELEMENTS_PER_CELL, but only read it at multiples of FIELD_ELEMENTS_PER_CELL.
This seems unnecessary. Why not just set is_cell_used[cell_indices[i]] = true in the outer loop and making the is_cell_used array smaller?
There was a problem hiding this comment.
Good point. Let's handle this on another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bunch of failed attempts to simplify
verify_cell_kzg_proof_batch(), I found a good spot to apply a scalpel.This refactoring is fairly clean and moves away four allocations from the main function into a smaller contained function.
The first commit only moves code (can be verified with
git diff --color-moved) while the second applies a few minor changes.There is a few more minor improvements that can be done, but they all have drawbacks. This seems quite clean IMO.