Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fire events to track user and recipient registries independently #375

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

WIP: Fire events to track user and recipient registries independently #375

wants to merge 5 commits into from

Conversation

daodesigner
Copy link
Collaborator

@daodesigner daodesigner commented Sep 15, 2021 •
edited
Loading

  • contract methods
  • contract events
  • subgraph mappings

closes #364
closes #365

@daodesigner daodesigner added the enhancement New feature or request label Sep 15, 2021
@daodesigner daodesigner self-assigned this Sep 15, 2021
@daodesigner daodesigner marked this pull request as ready for review September 15, 2021 08:40
@daodesigner daodesigner marked this pull request as draft September 15, 2021 08:43
@daodesigner daodesigner changed the title Fire events to track user and recipient registries independently WIP: Fire events to track user and recipient registries independently Sep 15, 2021
pettinarip
pettinarip reviewed Sep 15, 2021
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Question related to this: so, now we are going to keep track of the registries at the deployer level. Are we going to remove their references from the Factory? or are we going to keep them? I'm kind of lost in that aspect and how it will work now.

Base automatically changed from subgraph to develop September 21, 2021 20:11
@samajammin
Copy link
Member

Hey @daodesigner @pettinarip - going through all our open PRs. Is this something we still want to merge? Totally understand if it's no longer a near-term priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettinarip pettinarip pettinarip left review comments

Assignees

@daodesigner daodesigner

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@daodesigner @samajammin @pettinarip