Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename column/index fields of DataColumnSideCar #3747

Closed
wants to merge 1 commit into from

Conversation

asn-d6
Copy link
Contributor

@asn-d6 asn-d6 commented May 3, 2024

Working on #3745 had me confused on why sidecar.column is a list of cells, instead of the column index. This makes these fields a bit more clear.

It's an opinionated PR so feel free to NACK.

@ppopth
Copy link
Member

ppopth commented Jun 11, 2024

When I see column, I literally think of a column of a table, not an index. Like when you think of a row, you think of a row that has cells, right? not an index because an index doesn't have cells.

I think index also already makes sense, because it's an index in a column sidecar, so it's an index of a column.

@asn-d6 asn-d6 closed this Jul 16, 2024
@asn-d6
Copy link
Contributor Author

asn-d6 commented Jul 16, 2024

Closing due to lack of interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants