Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DepositReceipt to DepositRequest #3757

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

mkalinin
Copy link
Collaborator

@mkalinin mkalinin commented May 7, 2024

Renames DepositReceipt to DepositRequest to align with the EIP-7685 notation. Note that the renaming affects parameters and test formats.

The PR should be merged when there is an agreement that this change should be taken into effect.

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hwwhww
Copy link
Contributor

hwwhww commented May 8, 2024

lgtm and I like this alignment!

I'm holding my approval stamp in case we fat-fingered merge it.

@mkalinin mkalinin marked this pull request as ready for review June 4, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants