Update light client specifications for Electra #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electra introduces two changes that affect light client data handling: 1. The `ExecutionPayloadHeader` is extended with new fields. This is handled similarly as before with the Deneb fork. 2. The `BeaconState` generalized indices change due to lack of EIP-6493. This is handled by making the generalized index be fork dependent via a helper function that computes it dynamically. Furthermore, the case where pre-Electra light client data is consumed by an Electra based `LightClientStore` requires normalizing the shorter proof of the pre-Electra data to fit into the Electra data structure by prepending a zero hash.
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 21, 2024
Add missing Electra support for light client protocol: - ethereum/consensus-specs#3811 Tested against PR consensus-spec-tests, the test runner automatically picks up the new tests once available.
dapplion
reviewed
Jun 25, 2024
| execution_branch = ExecutionBranch( | ||
| compute_merkle_proof(block.message.body, EXECUTION_PAYLOAD_GINDEX)) | ||
| else: | ||
| # Note that during fork transitions, `finalized_header` may still point to earlier forks. |
There was a problem hiding this comment.
So far in Ethereum networks we have aligned fork epochs to light-client sync periods. Under what circumstance could that happen then?
There was a problem hiding this comment.
The head advances into the new fork before the finalized cp does. there is a short transition period during which the finalized header has to be normalized into the new datatype.
tersec
pushed a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 26, 2024
* extend light client protocol for Electra Add missing Electra support for light client protocol: - ethereum/consensus-specs#3811 Tested against PR consensus-spec-tests, the test runner automatically picks up the new tests once available. * workaround `version-2-0`: `Error: cannot instantiate: 'SomeUnsignedInt'` * fix initialization when Electra not scheduled * try reduce stack size in test * put correct sync committee branch version into DB * adjust fork schedule in light client data tests * further reduce stack size * split function into multiple parts * rename variable * regenerate test reports to cover new Electra tests * add Nim bug reference
wemeetagain
approved these changes
Jul 15, 2024
hwwhww
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electra introduces two changes that affect light client data handling:
The
ExecutionPayloadHeaderis extended with new fields. This is handled similarly as before with the Deneb fork.The
BeaconStategeneralized indices change due to lack of EIP-6493. This is handled by making the generalized index be fork dependent via a helper function that computes it dynamically. Furthermore, the case where pre-Electra light client data is consumed by an Electra basedLightClientStorerequires normalizing the shorter proof of the pre-Electra data to fit into the Electra data structure by prepending a zero hash.