Blobgas computation in CL #3813
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing new fields in the middle of an existing `Container` pointlessly breaks merkleization of all subsequent fields. In the case of `committee_bits`, it is also misleading, as `signature` only covers `data` inside `Attestation`.
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
potuz
reviewed
Jun 24, 2024
Co-authored-by: Potuz <potuz@prysmaticlabs.com>
mkalinin
reviewed
Jul 1, 2024
| @@ -423,10 +435,50 @@ class BeaconState(Container): | |||
| # [New in Electra:EIP7251] | |||
| pending_partial_withdrawals: List[PendingPartialWithdrawal, PENDING_PARTIAL_WITHDRAWALS_LIMIT] | |||
| pending_consolidations: List[PendingConsolidation, PENDING_CONSOLIDATIONS_LIMIT] # [New in Electra:EIP7251] | |||
| # [New in Electra: compute blob gas in CL] | |||
| excess_blob_gas: uint64 | |||
| base_fee_per_blob_gas: uint64 | |||
There was a problem hiding this comment.
do we need to keep this parameter to be in the state as it can be easily computed given the state?
| get_base_fee_per_blob_gas(state)): | ||
| return False | ||
|
|
||
| state.excess_blob_gas += execution_payload.blob_gas_used |
There was a problem hiding this comment.
This is an alternative version of #3800 where in addition to specifying the blob gas limit in CL, it lifts the whole basefee computation into the CL.
Potential advantages are: