-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-7691: Blob throughput increase #4023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ENT_INCLUSION_PROOF_DEPTH`
ppopth
reviewed
Nov 28, 2024
Co-authored-by: Pop Chunhapanya <haxx.pop@gmail.com>
hwwhww
force-pushed
the
electra-blob-count
branch
from
November 28, 2024 15:56
c0bba09
to
53e8d66
Compare
parithosh
reviewed
Dec 2, 2024
mehdi-aouadi
reviewed
Dec 3, 2024
Previous to this commit, the max blob count for EIP7594 was 8. Now that we have raised the target/max to 6/9 for Electra, the max blob count for EIP7594 no longer makes sense. I've raised the target/max for it to 9/12 as a placeholder. This also serves as an example of what changes are necessary to increase the blob count in the future.
This reverts commit f63f6e4.
mkalinin
approved these changes
Dec 6, 2024
hwwhww
commented
Dec 6, 2024
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add EIP-7691 to Electra.
This PR allows teams to configure it within the client software, but the final increased amount will need to be approved by ACD process.
This PR also includes a bump to
TARGET_BLOBS_PER_BLOCK_EIP7594
&MAX_BLOBS_PER_BLOCK_EIP7594
because the current maximum, 8 blobs, no longer makes sense. To be clear, these are just placeholder values and are used to test higher blob counts with PeerDAS.