Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update blob sidecar subnet computation for EIP-7691 #4067

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update blob sidecar subnet computation for EIP-7691 #4067

wants to merge 1 commit into from

Conversation

nflaig
Copy link
Contributor

@nflaig nflaig commented Dec 20, 2024 •
edited
Loading

Follow up on #4056 to update the blob sidecar subnet computation for EIP-7691 which does not use MAX_BLOBS_PER_BLOCK but BLOB_SIDECAR_SUBNET_COUNT, so I don't think it's covered by the previous PR.

Closes #4066

ppopth
ppopth approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@ppopth ppopth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jtraglia
jtraglia approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

@ppopth ppopth ppopth approved these changes

Assignees
No one assigned
Labels
Electra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EIP-7691 blob sidecar subnet computation not updated
3 participants
@nflaig @ppopth @jtraglia