Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special case markdown-rel-links to help when linking to eips.ethereum.org #5

Closed
SamWilsn opened this issue Jul 14, 2022 · 7 comments · Fixed by #94
Closed

Special case markdown-rel-links to help when linking to eips.ethereum.org #5

SamWilsn opened this issue Jul 14, 2022 · 7 comments · Fixed by #94
Assignees
@Hari-Bombon
Labels
good first issue Good for newcomers ready to implement Feature has reached rough consensus among editors and is ready to be implemented

Comments

@SamWilsn
Copy link
Contributor

SamWilsn commented Jul 14, 2022 •
edited
Loading

For example:

Error: error[markdown-rel-links]: non-relative link or image
  --> EIPS/eip-5190.md
   |
17 | This EIP also extends account-bound token from [EIP-4973](https://eips.ethereum.org/EIPS/eip-4973), but the difference is that it can be transferred to other account for mobility between managing device.
   |
   = help: use `./eip-4973.md` instead
@SamWilsn
Copy link
Contributor Author

Also do https://creativecommons.org/publicdomain/zero/1.0/.

@SamWilsn SamWilsn added the good first issue Good for newcomers label Jul 15, 2022
@SamWilsn SamWilsn added the ready to implement Feature has reached rough consensus among editors and is ready to be implemented label Aug 18, 2022
@JEAlfonsoP
Copy link
Contributor

I will work on this issue. Ty.

@JEAlfonsoP
Copy link
Contributor

JEAlfonsoP commented Feb 22, 2023 •
edited
Loading

Proposal for PR:

Modify relative_links.rs to add an AnnotationType::Help to the footer when regex matches:
link && !link

This was referenced Feb 25, 2023
Closed
Closed
@poojaranjan poojaranjan mentioned this issue Mar 7, 2023
Closed
9 tasks
@poojaranjan poojaranjan mentioned this issue Mar 16, 2023
Closed
6 tasks
SamWilsn added a commit to JEAlfonsoP/eipw that referenced this issue Apr 21, 2023
@SamWilsn
Bit of work on implementation and more tests (ethereum#5)
45bc5f9
@SamWilsn
Copy link
Contributor Author

Changed the example so that it works with other types of links, not just ones of the form [abc](def).

@SamWilsn SamWilsn mentioned this issue May 18, 2024
Closed
@Hari-Bombon
Copy link

@SamWilsn can you assign me this repo?

SamWilsn pushed a commit that referenced this issue May 20, 2024
@JEAlfonsoP @SamWilsn
Update relative_links.rs
a736a88 
Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update test.yaml

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update Cargo.toml

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update test.yaml

Update relative_links.rs

Update test.yaml

Update test.yaml

Update test.yaml

Update Cargo.toml

Update test.yaml

Update test.yaml

Update test.yaml

Update Cargo.toml

Update test.yaml

Update test.yaml

Update test.yaml

Update test.yaml

Update test.yaml

Update test.yaml

Update Cargo.toml

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update Cargo.toml

Update test.yaml

Update test.yaml

Update relative_links.rs

Update Cargo.toml

Update Cargo.toml

Update test.yaml

Update relative_links.rs

Update test.yaml

Update relative_links.rs

Update test.yaml

Update test.yaml

Update relative_links.rs

Update Cargo.toml

Update Cargo.toml

Update test.yaml

Update relative_links.rs

Update relative_links.rs

Bit of work on implementation and more tests (#5)

Update relative_links.rs

Update lint_markdown_relative_links.rs

Update relative_links.rs

Update lint_markdown_relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs
@SamWilsn
Copy link
Contributor Author

I've collected the tests JEAlfonsoP and I came up with over here: https://github.com/ethereum/eipw/tree/issue-5

Might be a good starting place for anyone working on this issue, though I can't promise they're totally up to date.

@JEAlfonsoP
Copy link
Contributor

I've collected the tests JEAlfonsoP and I came up with over here: https://github.com/ethereum/eipw/tree/issue-5

Might be a good starting place for anyone working on this issue, though I can't promise they're totally up to date.

Anything I can help just let me know. Cheers

aslikaya pushed a commit to aslikaya/eipw that referenced this issue Jun 11, 2024
@JEAlfonsoP @aslikaya
Update relative_links.rs
a9069ad 
Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update test.yaml

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update Cargo.toml

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update test.yaml

Update relative_links.rs

Update test.yaml

Update test.yaml

Update test.yaml

Update Cargo.toml

Update test.yaml

Update test.yaml

Update test.yaml

Update Cargo.toml

Update test.yaml

Update test.yaml

Update test.yaml

Update test.yaml

Update test.yaml

Update test.yaml

Update Cargo.toml

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update Cargo.toml

Update test.yaml

Update test.yaml

Update relative_links.rs

Update Cargo.toml

Update Cargo.toml

Update test.yaml

Update relative_links.rs

Update test.yaml

Update relative_links.rs

Update test.yaml

Update test.yaml

Update relative_links.rs

Update Cargo.toml

Update Cargo.toml

Update test.yaml

Update relative_links.rs

Update relative_links.rs

Bit of work on implementation and more tests (ethereum#5)

Update relative_links.rs

Update lint_markdown_relative_links.rs

Update relative_links.rs

Update lint_markdown_relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs
@aslikaya aslikaya mentioned this issue Jun 11, 2024
Merged
SamWilsn pushed a commit that referenced this issue Jun 19, 2024
@JEAlfonsoP @SamWilsn
Update relative_links.rs
5e3a684 
Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update test.yaml

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update Cargo.toml

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update test.yaml

Update relative_links.rs

Update test.yaml

Update test.yaml

Update test.yaml

Update Cargo.toml

Update test.yaml

Update test.yaml

Update test.yaml

Update Cargo.toml

Update test.yaml

Update test.yaml

Update test.yaml

Update test.yaml

Update test.yaml

Update test.yaml

Update Cargo.toml

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update Cargo.toml

Update test.yaml

Update test.yaml

Update relative_links.rs

Update Cargo.toml

Update Cargo.toml

Update test.yaml

Update relative_links.rs

Update test.yaml

Update relative_links.rs

Update test.yaml

Update test.yaml

Update relative_links.rs

Update Cargo.toml

Update Cargo.toml

Update test.yaml

Update relative_links.rs

Update relative_links.rs

Bit of work on implementation and more tests (#5)

Update relative_links.rs

Update lint_markdown_relative_links.rs

Update relative_links.rs

Update lint_markdown_relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs

Update relative_links.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hari-Bombon Hari-Bombon

Labels
good first issue Good for newcomers ready to implement Feature has reached rough consensus among editors and is ready to be implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds additional help for some links aslikaya/eipw
3 participants
@SamWilsn @JEAlfonsoP @Hari-Bombon