fix(pages/languages): persist render of close button for input

ethereum · Aug 30, 2023 · e2456e1 · e2456e1
1 parent 2f033ed
commit e2456e1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/src/components/Input/index.tsx b/src/components/Input/index.tsx
@@ -15,7 +15,7 @@ type WithIconProps = CommonProps & {
   /**
    * The Icon used to render `InputRightElement` on the right side of the input
    */
-  rightIcon?: JSX.Element
+  rightIcon: JSX.Element
   /**
    * Primarily for style props to be applied to the wrapper
    */

diff --git a/src/pages/languages.tsx b/src/pages/languages.tsx
@@ -1,5 +1,6 @@
 import {
   Box,
+  CloseButton,
   Flex,
   Heading,
   IconButton,
@@ -98,17 +99,14 @@ const LanguagesPage = ({ location }: PageProps<Queries.LanguagesPageQuery>) => {
             placeholder={searchString}
             onChange={(e) => setKeyword(e.target.value)}
             rightIcon={
-              keyword !== "" ? (
-                <IconButton
-                  icon={<MdClose />}
-                  onClick={resetKeyword}
-                  position="absolute"
-                  insetInlineEnd={1}
-                  aria-label={t("clear")}
-                  variant="ghost"
-                  _hover={{ svg: { fill: "primary" } }}
-                />
-              ) : undefined
+              <IconButton
+                icon={<MdClose />}
+                onClick={resetKeyword}
+                display={keyword === "" ? "none" : undefined}
+                aria-label={t("clear")}
+                variant="ghost"
+                _hover={{ svg: { fill: "primary" } }}
+              />
             }
           />
         </Box>