Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using chakra breakoints for footer #10915

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

amit-ksh
Copy link
Contributor

@amit-ksh amit-ksh commented Aug 11, 2023

Description

Replace the custom breakpoints with Chakra breakpoints

Related Issue

#9548
Closes #10752

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @amit-ksh

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was thinking after this review, I think part of our design system implementation we are planning on getting stories created for these. I can quickly put one together for this footer component before merging.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 17, 2023

✅ ethereum-org-website-dev deploy preview ready

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@corwintines corwintines merged commit a0fb188 into ethereum:dev Sep 29, 2023
This was referenced Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer - update breakpoints
3 participants