-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cleanup outstanding type errors (non-queried) #11340
Merged
corwintines
merged 3 commits into
ethereum:staging
from
TylerAPfledderer:fix/various-ts-errors
Oct 4, 2023
Merged
fix: cleanup outstanding type errors (non-queried) #11340
corwintines
merged 3 commits into
ethereum:staging
from
TylerAPfledderer:fix/various-ts-errors
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAPfledderer
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm,
jmcook1186 and
nhsz
as code owners
October 3, 2023 03:20
github-actions
bot
added
content 🖋️
This involves copy additions or edits
review needed 👀
labels
Oct 3, 2023
✅ ethereum-org-website-dev deploy preview ready
|
corwintines
reviewed
Oct 4, 2023
Co-authored-by: Corwin Smith <cssmittys@gmail.com>
corwintines
previously approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TylerAPfledderer I changed the base to staging so that this can be used for bugfix |
corwintines
approved these changes
Oct 4, 2023
This was referenced Oct 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses outstanding type errors throughout the project. (Checked via
yarn type-check
)This does not include errors in template files related to Gatsby data queries, as this may be excessive work when there is the anticipated migration to NextJS.
Related Issue
Fixes: #11372