Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup outstanding type errors (non-queried) #11340

Merged

Conversation

TylerAPfledderer
Copy link
Contributor

@TylerAPfledderer TylerAPfledderer commented Oct 3, 2023

Description

Addresses outstanding type errors throughout the project. (Checked via yarn type-check)

This does not include errors in template files related to Gatsby data queries, as this may be excessive work when there is the anticipated migration to NextJS.

Related Issue

Fixes: #11372

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 3, 2023

✅ ethereum-org-website-dev deploy preview ready

Co-authored-by: Corwin Smith <cssmittys@gmail.com>
corwintines
corwintines previously approved these changes Oct 4, 2023
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corwintines corwintines changed the base branch from dev to staging October 4, 2023 20:08
@corwintines corwintines dismissed their stale review October 4, 2023 20:08

The base branch was changed.

@corwintines
Copy link
Member

@TylerAPfledderer I changed the base to staging so that this can be used for bugfix

@corwintines corwintines merged commit 3de8933 into ethereum:staging Oct 4, 2023
3 checks passed
@TylerAPfledderer TylerAPfledderer deleted the fix/various-ts-errors branch October 4, 2023 20:28
This was referenced Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants