Add ChainName type for wallet network data #13497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add as optional supported_chains field type
use as initial example of ChainName type restriction; data ref: #13469
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
to be reverted
THYDUX
approved these changes
Aug 1, 2024
THYDUX
approved these changes
Aug 1, 2024
wackerow
commented
Aug 12, 2024
Comment on lines
+30
to
+41
| - name: Create Pull Request | ||
| uses: peter-evans/create-pull-request@v6 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| branch: update-chains | ||
| branch-suffix: timestamp | ||
| commit-message: | | ||
| Update chains data | ||
| base: dev | ||
| title: Update chains data | ||
| body: Automated update of chains data from https://chainid.network/chains.json | ||
| labels: update 🔄 |
There was a problem hiding this comment.
More info on usage: https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#usage
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
Status: Stale
wackerow
added
needs dev approval 🧑💻
corwintines
approved these changes
Nov 20, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently we've been collecting additional information from wallet providers related to the different networks their software supports. This led to the issue of not yet having a clean way to reference network/chain names when adding this data to the code base.
This solution utilizes EIP-155 with a chainid.network endpoint which serves a JSON object with all of their chain data.
src/data/chains.ts) using theas constkeywordChainNameis created from the above TypeScript object using(typeof chains)[number]["name"]supported_chainsfield, accepted an array ofChainName