Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svg imports in SB #13570

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix svg imports in SB #13570

merged 2 commits into from
Aug 6, 2024

Conversation

pettinarip
Copy link
Member

Description

Adds the svgr loader in SB to handle svg files as with Nextjs and updates the configs and types.

@github-actions github-actions bot added config ⚙️ Changes to configuration files tooling 🔧 Changes related to tooling of the project labels Aug 3, 2024
Copy link

netlify bot commented Aug 3, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 8986fb1
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66b0997e1a208e0008060922
😎 Deploy Preview https://deploy-preview-13570--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 41 (🔴 down 10 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 10 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://react-svgr.com/docs/next/

This config will now also support .svg?url import syntax to be used with the Image component.

@TylerAPfledderer
Copy link
Contributor

@pettinarip Chromatic failure here is now expected; verified that the feedback widget model is missing its data-testid for the failed snapshot (might've been removed by mistake when migrating to ShadCN)

@pettinarip pettinarip changed the title Fix svg in SB Fix svg imports in SB Aug 5, 2024
@corwintines corwintines merged commit afa39a7 into dev Aug 6, 2024
10 checks passed
@corwintines corwintines deleted the fix-svg-storybook branch August 6, 2024 02:53
This was referenced Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙️ Changes to configuration files tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants