Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove date from whitepaper page #13645 #13710

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

gks2022004
Copy link
Contributor

@gks2022004 gks2022004 commented Aug 23, 2024

Remove date from the whitepaper page

Description

This pull request modifies the Static Layout component to hide the "Page last updated" text specifically on the Whitepaper page. The change involves adding a conditional check to prevent rendering the timestamp for the /whitepaper route.

The main changes include:

  1. Added a condition to check both the slug and asPath before rendering the "Last Updated" text.
  2. The text will now only render if the page is not the Whitepaper page.

Issue

fixes #13645
Fixes 13645 - remove date from whitepaper

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Aug 23, 2024
Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 65cb88a
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66d7e9749451250008727438
😎 Deploy Preview https://deploy-preview-13710--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 44 (🔴 down 6 from production)
Accessibility: 94 (🟢 up 2 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@gks2022004 gks2022004 changed the title Remove date from whitepaper page #13645 fix: Remove date from whitepaper page #13645 Aug 28, 2024
@corwintines corwintines self-assigned this Sep 4, 2024
src/layouts/Static.tsx Outdated Show resolved Hide resolved
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gks2022004!

@corwintines corwintines merged commit 2542880 into ethereum:dev Sep 4, 2024
2 of 3 checks passed
Copy link

gitpoap-bot bot commented Sep 4, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@gks2022004 gks2022004 deleted the removedate branch September 4, 2024 10:44
@corwintines corwintines mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: remove date from whitepaper page
2 participants