Design system: button theming #13822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"solid" default variant, "outline" includes color, `isSecondary` removes color from default outline/ghost states
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
wackerow
added
the
design system
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
commented
Sep 8, 2024
tailwind.config.ts
Outdated
| @@ -203,7 +203,7 @@ const config = { | |||
| 0px -3px 2px 0px rgba(0, 0, 0, 0.14) inset`, | |||
| // TODO: From current theme. Deprecate for 'button-hover' | |||
| primary: "4px 4px 0px 0px hsla(var(--primary))", | |||
| "button-hover": "4px 4px 0 0 hsla(var(--primary-low-contrast))", | |||
| "button-hover": "4px 4px 0 0 hsla(var(--orange-900))", | |||
There was a problem hiding this comment.
We're approaching a point where we have no more references to the orange color palette, and it is not present in the DS... The full yellow color palette is being imported in a separate branch. After that, we can migrate this to --yellow-900 and should be able to remove the entire orange palette.
deprecate single-use `button-hover` tailwind token; applied directly at ui/button component level
tw `primary`, `button-hover` shadow tokens; chakra `primary` shadow token
nloureiro
approved these changes
Sep 9, 2024
these links should be lighter purple, is that in a separate PR or is it a button link? |
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends
colors-1branch in PR:(Can be merged in any order)
Description
buttonVariantsin newui/buttons/Button.tsxcomponent.Figma:
Related Issue
Design system