Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TitleCardList #13963

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Remove TitleCardList #13963

merged 2 commits into from
Sep 26, 2024

Conversation

minimalsm
Copy link
Contributor

@minimalsm minimalsm commented Sep 25, 2024 •
edited by wackerow
Loading

Description

TitleCardList was deprecated as part of the recent homepage redesign. Removing as part of #13946

Related Issue

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Sep 25, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 67557e4
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66f41ea90d468500086dcc42
😎 Deploy Preview https://deploy-preview-13963--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 47 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@minimalsm minimalsm mentioned this pull request Sep 25, 2024
Open
65 tasks
wackerow
wackerow approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minimalsm!

pettinarip
pettinarip approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh yeah, ty

@pettinarip pettinarip merged commit 298d126 into dev Sep 26, 2024
8 of 10 checks passed
@pettinarip pettinarip deleted the removeTitleCardList branch September 26, 2024 10:06
This was referenced Oct 2, 2024
Merged
Merged
@pettinarip pettinarip added the hacktoberfest Track hacktoberfest activity label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@pettinarip pettinarip pettinarip approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

Assignees
No one assigned
Labels
hacktoberfest Track hacktoberfest activity tooling 🔧 Changes related to tooling of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minimalsm @pettinarip @wackerow