[ShadCN] refactor(icons): use react-icons IconBase composition
#13970
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@TylerAPfledderer this looks great! didn't know we had a IconBase in react-icons.
cc @wackerow
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Hey @TylerAPfledderer would you need some help on this? its gaining priority now that we need to migrate a bunch of components that use these icons. Would be nice to have this in place to avoid converting all the icons to svgs. I'll test it locally in the meantime. |
|
@pettinarip yes, that would be helpful. Getting bogged down over here at the moment. I would point out that when double-checking changes to the icons where rendered in components/pages, that if a color was added, it might need to be added to the
|
|
I've reverted the StakingHierarchy related icons to migrate them later as they are a bit related to that component logic. I don't think we need to address that in this PR. |
There was a problem hiding this comment.
@TylerAPfledderer I have tested this and it looks good to me. I wonder if you are working on or expecting to do more things in this PR.
Left a comment but I think we should tackle that in a separate PR.
| @@ -1,7 +1,14 @@ | |||
| import type { SVGAttributes } from "react" | |||
| import { IconProps } from "@chakra-ui/react" | |||
|
|
|||
| export const commonIconDefaultProps: IconProps = { | |||
There was a problem hiding this comment.
This is the next iteration we need to do, right? replace this with commonIconDefaultAttrs. If you agree, we can tackle that in a different PR, just to avoid blocking this PR.
There was a problem hiding this comment.
@pettinarip Yes, that is correct. Thank you!
|
@pettinarip I have not considered anything additional for this PR. |
pettinarip
requested review from
wackerow,
corwintines and
minimalsm
as code owners
There was a problem hiding this comment.
@TylerAPfledderer I fixed a few minor things. Overall I think the icons work well. Thanks for the hard work on the refactor.
Description
Related Issue