Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadcn migrate - BugBountyCards #14000

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

saurabhburade
Copy link
Contributor

Description

  • Migrate BugBountyCards to tailwind
  • Remove unused Divider

Related Issue

#13946

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 1fb841a
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6718859cea580e0008d585aa
😎 Deploy Preview https://deploy-preview-14000--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 45 (🔴 down 8 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (🟢 up 7 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@saurabhburade saurabhburade marked this pull request as ready for review October 1, 2024 05:13
defihook

This comment was marked as spam.

@pettinarip pettinarip mentioned this pull request Oct 2, 2024
65 tasks
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhburade looks good. Left a few minor comments and waiting for design confirmation.

src/components/BugBountyCards.tsx Outdated Show resolved Hide resolved
src/components/BugBountyCards.tsx Outdated Show resolved Hide resolved
src/components/BugBountyCards.tsx Outdated Show resolved Hide resolved
src/components/BugBountyCards.tsx Outdated Show resolved Hide resolved
src/components/BugBountyCards.tsx Outdated Show resolved Hide resolved
@saurabhburade
Copy link
Contributor Author

On it ser!!! modifying with requested changes.

@pettinarip pettinarip added the needs design approval 🧑‍🎨 Approval from a designer is needed before merging label Oct 3, 2024
@pettinarip pettinarip added the hacktoberfest Track hacktoberfest activity label Oct 17, 2024
I like it

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
src/components/BugBountyCards.tsx Outdated Show resolved Hide resolved
@pettinarip pettinarip merged commit b7fcc90 into ethereum:dev Oct 28, 2024
6 of 7 checks passed
This was referenced Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Track hacktoberfest activity needs design approval 🧑‍🎨 Approval from a designer is needed before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants