-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate ExpandableCard component to shadcn #14017
feat: migrate ExpandableCard component to shadcn #14017
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start @kushagrasarathe! The approach you took is perfect. Left a few requests on color token changes to match the Design System.
This is how I see it on https://deploy-preview-14017--ethereumorg.netlify.app/en/contributing/style-guide/
We would also need to align the text on the header texts to the left.
Hey @pettinarip pushed the changes requestd 🙌
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kushagrasarathe !
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Migrates
ExpandableCard
component to ShadCN from ChakraDescription
This PR updates the ExpandableCard to use ShadcnUI's accordion component instead of Chakra component. Styles have been updated for both light and dark version.
Note
@pettinarip I've used the
accordion
from/tailwind
directory and did not directly overwrite the classes in the primitives, instead added classes in theExpandableCard
component to keep the UI similar to how it was with Chakra.Lemme know if this approach doesn't look good, happy to update it.
Also the default behaviour on shadcn accordion doesn't allow the accordion it to be closed if clicked on content, I can add this using mouse events, thoughts?
Related Issue
#13946