Migrate DatesAndTimeline component to Shadcn/Tailwind
#14071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xgun
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
config ⚙️
0xgun
force-pushed
the
migrate-DatesAndTimeline
branch
from
5162c69 to
f3f3064
Compare
|
@pettinarip could you please review this PR |
pettinarip
requested changes
Oct 28, 2024
There was a problem hiding this comment.
@0xgun looks good visually but left a few comments to use the cn function and defined DS colors.
|
Hey @pettinarip , I have made all the requested changes |
pettinarip
reviewed
Oct 31, 2024
| variant="outline" | ||
| isDisabled={date.link === APPLICATION_URL && !isLive} // Application only | ||
| aria-disabled={date.link === APPLICATION_URL && !isLive} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
DatesAndTimelinecomponent to Shadcn/Tailwind from ChakraRelated Issue
#13946