Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Gitstars component to shadcn/tailwind #14073

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

Baystef
Copy link
Contributor

@Baystef Baystef commented Oct 5, 2024

Description

Migrated the GitStars component styling to Tailwind/Shadcn

Related Issue

#13946

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 95ccc38
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/670e709abf875b000843239b
😎 Deploy Preview https://deploy-preview-14073--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 50 (🔴 down 3 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip mentioned this pull request Oct 8, 2024
65 tasks
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @Baystef, left a few comments

src/components/GitStars.tsx Outdated Show resolved Hide resolved
src/components/GitStars.tsx Outdated Show resolved Hide resolved
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baystef i've polished a bit the styles for this component. Thanks for the PR

@Baystef
Copy link
Contributor Author

Baystef commented Oct 15, 2024

@Baystef i've polished a bit the styles for this component. Thanks for the PR

Thanks. Is there a design you're following? @pettinarip

@pettinarip pettinarip merged commit 00b026e into ethereum:dev Oct 15, 2024
10 checks passed
@pettinarip pettinarip added the hacktoberfest Track hacktoberfest activity label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Track hacktoberfest activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants