migrated trilemma modal to shadcn ui sheet component #14102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atharv-av
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
the
dependencies 📦
✅ Deploy Preview for ethereumorg canceled.
|
pettinarip
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Thanks @atharv-av.
There are a few files that shouldn't be modified. LMK if you need help.
|
Hey @atharv-av wanted to know if you are blocked on this PR or need help. LMK thanks! |
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
Status: Stale
pettinarip
approved these changes
Dec 24, 2024
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trilemma modal previously used chakra imports. I replaced them with shadcn ui and tailwind css. Also, I used components from
@/components/ui/flex