Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename quiz keys, use unique namespace #14148

Merged
merged 6 commits into from
Nov 18, 2024
Merged

refactor: rename quiz keys, use unique namespace #14148

merged 6 commits into from
Nov 18, 2024

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Oct 9, 2024

Description

  • Renames all quiz question keys to use a quiz name instead of alphabetical prefix
  • Intended to avoid conflicts between new quizzes

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Oct 9, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 236acdb
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/673b888d119825000891f18a
😎 Deploy Preview https://deploy-preview-14148--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 49 (🔴 down 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow changed the title refactor: rename quiz keys with unique name refactor: rename quiz keys, use unique namespace Oct 10, 2024
@wackerow wackerow mentioned this pull request Oct 21, 2024
Merged
@corwintines corwintines self-assigned this Nov 18, 2024
@corwintines corwintines merged commit 7c9af69 into dev Nov 18, 2024
3 of 4 checks passed
@corwintines corwintines deleted the rename-quiz-keys branch November 18, 2024 18:35
This was referenced Nov 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees

@corwintines corwintines

Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wackerow @corwintines