Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate HorizontalCard to tailwind #14226

Merged
merged 5 commits into from
Dec 27, 2024
Merged

feat: migrate HorizontalCard to tailwind #14226

merged 5 commits into from
Dec 27, 2024

Conversation

kushagrasarathe
Copy link
Contributor

Migrates HorizontalCard component to tailwind from Chakra

Description

This PR updates the HorizontalCard to use tailwindcss instead of Chakra ui. Styles have been updated for both light and dark version.

Related Issue

#13946

@netlify Netlify
Copy link

netlify bot commented Oct 24, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 136e3a9
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/676db34a5854400008c50f5a
😎 Deploy Preview https://deploy-preview-14226--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 50 (🔴 down 6 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (🟢 up 30 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@isabelladebrito isabelladebrito added the hacktoberfest Track hacktoberfest activity label Oct 24, 2024
@kushagrasarathe kushagrasarathe mentioned this pull request Oct 25, 2024
Open
5 tasks
pettinarip
pettinarip requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushagrasarathe looking good, left a few comments.

src/components/HorizontalCard.tsx Outdated Show resolved Hide resolved
src/pages/gas.tsx Outdated Show resolved Hide resolved
src/pages/stablecoins.tsx Outdated Show resolved Hide resolved
src/pages/wallets/index.tsx Outdated Show resolved Hide resolved
src/pages/eth.tsx Outdated Show resolved Hide resolved
src/pages/gas.tsx Outdated Show resolved Hide resolved
pettinarip
pettinarip requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushagrasarathe looking good, left a few comments.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Dec 26, 2024
@kushagrasarathe
Copy link
Contributor Author

hey @pettinarip can you review this please, thanks :)

pettinarip
pettinarip approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kushagrasarathe, looks good!

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Dec 27, 2024
@pettinarip pettinarip merged commit 0ed6557 into ethereum:dev Dec 27, 2024
10 checks passed
This was referenced Jan 2, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettinarip pettinarip pettinarip approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
hacktoberfest Track hacktoberfest activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kushagrasarathe @pettinarip @isabelladebrito