Fix maxDeposit and maxMint on the 4626 page
#14365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's "for the receiver": The idea is to allow enabling blocklists at the vault level. If you are going to restrict holding vault shares by certain addresses, you would stop it both at transfer and deposit/mint. The maxDeposit/maxMint should reflect that. It is a bit arbitrary, because blocklists could also be implemented on the function caller, and not just the token receiver, but that's what it is.
alcueca
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
❌ Deploy Preview for ethereumorg failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the description of the
maxDepositandmaxMintsections to match faithfully the 4626 standard.See the original EIP, in that it specifies that the function return is calculated with
receiverbeing the receiver of the shares, and not necessarily the caller:The idea is to allow enabling blocklists at the vault level. If you are going to restrict holding vault shares by certain addresses, you would stop it both at transfer and deposit/mint. The maxDeposit/maxMint should reflect that.
It is a bit arbitrary, because blocklists could also be implemented on the function caller, and not just the token receiver, but that's what it is.