Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove devcon banner and fix broken imageURL for rss feed #14401

Merged
merged 2 commits into from
Nov 26, 2024
Merged

remove devcon banner and fix broken imageURL for rss feed #14401

merged 2 commits into from
Nov 26, 2024

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented Nov 26, 2024 •
edited
Loading

Description

  • Removes road to devcon banner
  • Fixes wallet-data build error
  • Image fallback for 404 images on rss feed and community events

@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 23a5ab1
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/674612024b2b4f000860a967
😎 Deploy Preview https://deploy-preview-14401--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 51 (🔴 down 3 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines changed the title remove devcon banner remove devcon banner and fix broken imageURL for rss feed Nov 26, 2024
@corwintines corwintines merged commit e1badca into dev Nov 26, 2024
8 of 10 checks passed
@corwintines corwintines deleted the removeDevconGrantsBanner branch November 26, 2024 19:30
This was referenced Nov 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettinarip pettinarip pettinarip approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corwintines @pettinarip