Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrated TransaltionBanner #14546

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

ameeetgaikwad
Copy link
Contributor

Description

  • This PR continues our migration from Chakra UI to Tailwind CSS by updating the TranslationBanner component. Key changes include:
  • Replaced Chakra UI components (Box, CloseButton, Flex, Heading) with native HTML elements styled with Tailwind CSS
  • Migrated from ButtonLink to the new Button component with asChild prop
  • Updated styling to match existing design using Tailwind classes
  • Removed Chakra-specific hooks (useToken)
  • Simplified conditional rendering using early return pattern
  • Maintained RTL support and existing functionality
  • The changes are purely presentational and should maintain the same user experience while reducing our dependency on Chakra UI.

Related Issue

Continues the work from #13946
Part of the broader Chakra UI to Tailwind CSS migration effort

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 4fdff2d
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6772afe7c3e8780008c30176
😎 Deploy Preview https://deploy-preview-14546--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 41 (🔴 down 14 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (🟢 up 30 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip mentioned this pull request Dec 26, 2024
41 tasks
Copy link

gitguardian bot commented Dec 30, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pettinarip pettinarip merged commit a383c82 into ethereum:dev Dec 31, 2024
10 checks passed
This was referenced Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants