Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate filecontributors to shadcn #14553

Merged

Conversation

plvzfq-rit
Copy link
Contributor

@plvzfq-rit plvzfq-rit commented Dec 27, 2024

Description

Migrated FileContributors.tsx from Chakra UI to Shadcn. Reutilized built-in Typescript components, e.g., Button, InlineLink, Modal, Translation, Flex, VStack, ListItem, and UnorderedList. Avatar left alone as per specification. Text also left alone for now since others seem to use it. Changes were done by using Tailwind classes to replace old Chakra UI parameters.

Update: Changed out the OldText dependency with native <p> tags combined with Tailwind classes.
Attribution: Had some trouble with Tailwind's visible/invisible classes not working properly in Chrome. Referenced this post.

Related Issue

#13946

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 7156ac8
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6773f43a2d89f4000852881e
😎 Deploy Preview https://deploy-preview-14553--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🔴 down 8 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (🟢 up 30 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip mentioned this pull request Dec 27, 2024
41 tasks
Copy link

gitguardian bot commented Dec 30, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @plvzfq-rit

This is how I see the list in the preview
image

Seems that we need to set a min height to the container.

src/components/FileContributors.tsx Outdated Show resolved Hide resolved
src/components/FileContributors.tsx Outdated Show resolved Hide resolved
@plvzfq-rit
Copy link
Contributor Author

Hi @pettinarip, happy new year.
I've changed the Button class from the old to the new. I also found out that the max sizing was wrong after looking at the generated source code in the original, so I upped it from max-h-3 to max-h-64. Should be all good now+

@github-actions github-actions bot added the dependencies 📦 Changes related to project dependencies label Dec 31, 2024
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those fixes @plvzfq-rit.

I've pushed a commit adding ScrollArea from Shadcn to get a better looking scrolling and avoid potential overflows inside the modal.

@plvzfq-rit
Copy link
Contributor Author

Thanks as well @pettinarip!

@plvzfq-rit
Copy link
Contributor Author

plvzfq-rit commented Jan 1, 2025

By the by, I had some trouble with some of the CSS for hiding components at certain screen sizes. Turns out it was a Chrome issue. Bypassed it through the code in this StackOverflow post. Thought I should put in some attribution+

@pettinarip
Copy link
Member

By the by, I had some trouble with some of the CSS for hiding components at certain screen sizes. Turns out it was a Chrome issue. Bypassed it through the code in this StackOverflow post. Thought I should put in some attribution+

Interesting. Thanks for sharing @plvzfq-rit

@pettinarip pettinarip merged commit 46d0771 into ethereum:dev Jan 6, 2025
6 checks passed
@corwintines corwintines mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 📦 Changes related to project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants