-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate filecontributors to shadcn #14553
Migrate filecontributors to shadcn #14553
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @plvzfq-rit
This is how I see the list in the preview
Seems that we need to set a min height to the container.
Co-authored-by: Pablo Pettinari <pettinarip@gmail.com>
…x ContributorList
…om/plvzfq-rit/ethereum-org-website into migrate-filecontributors-to-shadcn
Hi @pettinarip, happy new year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those fixes @plvzfq-rit.
I've pushed a commit adding ScrollArea
from Shadcn to get a better looking scrolling and avoid potential overflows inside the modal.
Thanks as well @pettinarip! |
By the by, I had some trouble with some of the CSS for hiding components at certain screen sizes. Turns out it was a Chrome issue. Bypassed it through the code in this StackOverflow post. Thought I should put in some attribution+ |
Interesting. Thanks for sharing @plvzfq-rit |
Description
Migrated
FileContributors.tsx
from Chakra UI to Shadcn. Reutilized built-in Typescript components, e.g.,Button
,InlineLink
,Modal
,Translation
,Flex
,VStack
,ListItem
, andUnorderedList
. Avatar left alone as per specification.Text also left alone for now since others seem to use it.Changes were done by using Tailwind classes to replace old Chakra UI parameters.Update: Changed out the OldText dependency with native
<p>
tags combined with Tailwind classes.Attribution: Had some trouble with Tailwind's visible/invisible classes not working properly in Chrome. Referenced this post.
Related Issue
#13946