Cleanup global styles #7564
Merged
Cleanup global styles #7564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into the chakra theme configuration file
pettinarip
requested review from
samajammin,
wackerow,
corwintines,
minimalsm and
jmcook1186
as code owners
minimalsm
reviewed
Aug 25, 2022
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
corwintines
reviewed
Aug 25, 2022
| @@ -1,7 +1,7 @@ | |||
| export type Colors = typeof colors | |||
|
|
|||
| const colors = { | |||
| grey: { | |||
| gray: { | |||
There was a problem hiding this comment.
I see in the figma this is spelt grey. Should that be updated there to reflect this change. I have no strong preference on the spelling we use, just should be consistent.
There was a problem hiding this comment.
Good call, yes.
To clarify, Chakra is using gray. Calling @nloureiro to update those names in the design system and keep the consistency.
corwintines
reviewed
Aug 25, 2022
| @@ -7,7 +7,6 @@ import { IntlProvider } from "react-intl" | |||
| import { LocaleProvider } from "gatsby-theme-i18n" | |||
|
|
|||
| import { lightTheme, darkTheme } from "../theme" | |||
| import GlobalStyle from "./GlobalStyle" | |||
There was a problem hiding this comment.
This was the only use of this component, so I think we can delete it :)
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 33m |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GlobalStylesin favor of the reset rules applied by Chakra.GlobalStylesinto the Chakra theme folder. To have everything in one place.GlobalStylescomponent.Related Issue
#6374