Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory accesses #7728

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Fix memory accesses #7728

merged 1 commit into from
Sep 8, 2022

Conversation

ethosdev
Copy link
Contributor

@ethosdev ethosdev commented Sep 7, 2022

The length is inclusive of the first element (not in addition to it), so need to -1 when accessing memory

The length is inclusive of the first element (not in addition to it), so need to -1
@vercel
Copy link

vercel bot commented Sep 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ethereum-org-website ❌ Failed (Inspect) Sep 7, 2022 at 4:23AM (UTC)

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Sep 7, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 7, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 38m

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ethosdev, confirmed on discord this was incorrect

@minimalsm minimalsm merged commit 5963a68 into ethereum:dev Sep 8, 2022
@ethosdev
Copy link
Contributor Author

ethosdev commented Sep 8, 2022

Thanks @ethosdev, confirmed on discord this was incorrect

Pleasure, thanks :)

@corwintines corwintines mentioned this pull request Sep 8, 2022
ethosdev added a commit to ethosdev/ethereum-org-website that referenced this pull request Sep 10, 2022
The length is inclusive of the first element (not in addition to it), so need to -1 when accessing memory

This commit fixes what was missed (sorry) by ethereum#7728
@ethosdev ethosdev deleted the patch-2 branch September 10, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants