Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tag component to use Chakra #7735

Merged
merged 5 commits into from
Sep 8, 2022
Merged

Conversation

ecrecover
Copy link
Contributor

@ecrecover ecrecover commented Sep 7, 2022

Description

Migrate Tag component from styled-components to ChakraUI

Related Issue

#6374

@vercel
Copy link

vercel bot commented Sep 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ethereum-org-website ❌ Failed (Inspect) Sep 7, 2022 at 3:23PM (UTC)

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 7, 2022

✅ ethereum-org-website-dev deploy preview ready

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing start @Hannsu 🎉 great to see that you decided to go and style the native Chakra styles for the Tag, good call.

I've left a few comments & changes request.

src/@chakra-ui/gatsby-plugin/components/Tag.ts Outdated Show resolved Hide resolved
src/@chakra-ui/gatsby-plugin/components/Tag.ts Outdated Show resolved Hide resolved
src/@chakra-ui/gatsby-plugin/components/Tag.ts Outdated Show resolved Hide resolved
src/@chakra-ui/gatsby-plugin/components/Tag.ts Outdated Show resolved Hide resolved
src/@chakra-ui/gatsby-plugin/components/Tag.ts Outdated Show resolved Hide resolved
src/@chakra-ui/gatsby-plugin/components/Tag.ts Outdated Show resolved Hide resolved
src/@chakra-ui/gatsby-plugin/foundations/shadows.ts Outdated Show resolved Hide resolved
src/components/Tag.tsx Outdated Show resolved Hide resolved
src/components/Tag.tsx Outdated Show resolved Hide resolved
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @Hannsu! thanks for helping us in this migration.

@Hannsu be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳!

@pettinarip pettinarip merged commit b73a541 into ethereum:dev Sep 8, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Sep 8, 2022

Woohoo, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Ethereum.org Contributor:
GitPOAP: 2022 Ethereum.org Contributor GitPOAP Badge

Head on over to GitPOAP.io and connect your GitHub account to mint!

@pettinarip
Copy link
Member

@all-contributors please add @Hannsu for code

@allcontributors
Copy link
Contributor

@pettinarip

I've put up a pull request to add @Hannsu! 🎉

@ecrecover
Copy link
Contributor Author

Awesome job @Hannsu! thanks for helping us in this migration.

@Hannsu be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳!

Thanks a lot @pettinarip for your help! I've joined discord and minted the awesome POAP. Surely I'll contribute further💪

@corwintines corwintines mentioned this pull request Sep 8, 2022
@pettinarip pettinarip mentioned this pull request Sep 24, 2022
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants