Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Added datasource BloomFilterTest #1268

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Conversation

derekzuk
Copy link
Contributor

The datasource BloomFilter class is based on the one here: https://github.com/MagnusS/Java-BloomFilter, so I adapted the corresponding test to work with it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 57.267% when pulling a13d207 on derekzuk:develop into 8731060 on ethereum:develop.

Copy link
Collaborator

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkalinin
Copy link
Contributor

Good job, man! Especially on testExpectedFalsePositiveProbability(), thank you!

@mkalinin mkalinin merged commit df03d54 into ethereum:develop Mar 27, 2019
@derekzuk
Copy link
Contributor Author

No need to thank me! This is a modification of https://github.com/MagnusS/Java-BloomFilter/blob/master/test/com/skjegstad/utils/BloomFilterTest.java . I'm looking forward to putting together more unit tests. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants