Eip 214: new STATICCALL opcode #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make future modifications less error prone
mkalinin
reviewed
Aug 24, 2017
| @@ -137,4 +137,9 @@ String validateTransactionChanges(BlockStore blockStore, Block curBlock, Transac | |||
| * EIP211: https://github.com/ethereum/EIPs/pull/211 | |||
| */ | |||
| boolean eip211(); | |||
|
|
|||
| /** | |||
| * EIP211: https://github.com/ethereum/EIPs/pull/214 | |||
There was a problem hiding this comment.
pls, fix typo in EIP number
| Call, | ||
|
|
||
| /** | ||
| * Indicates that the opcode has value parameter (3rd on stack) |
There was a problem hiding this comment.
Looks like description does not relate to flag semantics, doesn't it?
| @@ -974,6 +980,7 @@ else if (oldValue != null && newValue.isZero()) { | |||
| case LOG3: | |||
| case LOG4: { | |||
|
|
|||
| if (program.isStaticCall()) throw new Program.StaticCallModificationException(); | |||
There was a problem hiding this comment.
LOG0 is not affected by the spec, thus, it should be excepted
There was a problem hiding this comment.
Already affected: https://github.com/ethereum/EIPs/pull/214/files
| @@ -687,7 +707,32 @@ public int asInt() { | |||
| } | |||
| } | |||
|
|
|||
| ; | |||
| public enum CallFlags { | |||
There was a problem hiding this comment.
Maybe defined a method for each flag check in OpCode? Just to replace op.getCallFlags().contains(CallFlags.Stateless) with something like op.isStateless() and increase code readability
mkalinin
reviewed
Aug 24, 2017
| @@ -1288,6 +1302,10 @@ else if (oldValue != null && newValue.isZero()) { | |||
| } | |||
| } | |||
|
|
|||
| private void checkStatic(Program program) { | |||
There was a problem hiding this comment.
Missed that one. This method is not used. do we need to keep it?
mkalinin
approved these changes
Aug 24, 2017
|
Relates to #923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of ethereum/EIPs#214