EIP-213 precompiles for BN128 addition and scalar multiplication #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implementation of ethereum/EIPs#213 |
Nashatyrev
reviewed
Aug 29, 2017
| // spend all gas on failure, push zero and revert state changes | ||
| this.refundGas(0, "call pre-compiled"); | ||
| this.stackPushZero(); | ||
| track.rollback(); |
There was a problem hiding this comment.
M.b. refactor PrecompiledContract a bit and make it similar to regular call, I.e. leave only execute() there and throw OGException if not enough gas for supplied data, and other custom exceptions if invalid data supplied (there you can supply a detailed description on why the call failed) ?
There was a problem hiding this comment.
Good idea, but let's do refactoring out of this PR. I spawned related issue #926 for that
Conflicts: ethereumj-core/src/main/java/org/ethereum/vm/program/Program.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.