Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: add enum aliases #206

Merged
merged 2 commits into from
Nov 27, 2019
Merged

rust: add enum aliases #206

merged 2 commits into from
Nov 27, 2019

Conversation

axic
Copy link
Member

@axic axic commented Mar 13, 2019 •
edited
Loading

Part of #168.

@axic axic requested a review from jakelang March 13, 2019 19:48
@jakelang
Copy link
Contributor

needs rebase.

@axic
Copy link
Member Author

axic commented Mar 19, 2019

It turns out supporting enum type aliases properly was only merged into rustc on 19th Jan: rust-lang/rust#56225

@axic axic force-pushed the rust-enum-aliases branch from 46daa11 to 2faec7e Compare March 19, 2019 19:24
@axic axic force-pushed the rust-enum-aliases branch from 2faec7e to 8914936 Compare April 24, 2019 08:52
@axic axic force-pushed the rust-enum-aliases branch from 8914936 to aaa6d14 Compare May 14, 2019 12:00
@axic axic force-pushed the rust-enum-aliases branch from aaa6d14 to 75cde21 Compare June 4, 2019 15:55
@axic axic changed the title Add enum aliases to Rust rust: add enum aliases Jun 7, 2019
@axic axic mentioned this pull request Jul 3, 2019
Merged
@axic
Copy link
Member Author

axic commented Jul 4, 2019

Wow, apparently this is coming in rustc 1.37: rust-lang/rust#61682

@axic axic force-pushed the rust-enum-aliases branch from 75cde21 to e84bca3 Compare July 4, 2019 19:08
@axic axic force-pushed the rust-enum-aliases branch from e84bca3 to bbe6b7f Compare July 25, 2019 10:36
@axic axic force-pushed the rust-enum-aliases branch 3 times, most recently from 32664f9 to 3d84c51 Compare August 11, 2019 09:16
@axic
Copy link
Member Author

axic commented Aug 21, 2019 •
edited
Loading

Woohoo, 1.37 was released.

@axic axic force-pushed the rust-enum-aliases branch from 3d84c51 to b18b20e Compare August 21, 2019 20:49
@axic axic force-pushed the rust-enum-aliases branch 2 times, most recently from 2ca440e to 4f4da10 Compare November 26, 2019 23:00
@axic axic force-pushed the rust-enum-aliases branch from 4f4da10 to a88ae70 Compare November 27, 2019 22:12
@axic axic force-pushed the rust-enum-aliases branch from 3cc59d5 to 6ffb0f9 Compare November 27, 2019 22:16
@axic axic merged commit f2aa41d into master Nov 27, 2019
@axic axic deleted the rust-enum-aliases branch November 27, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

@jakelang jakelang jakelang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axic @jakelang @chfast