EVM test tool #85
EVM test tool #85
Conversation
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
- Coverage 93.78% 90.45% -3.33%
==========================================
Files 16 18 +2
Lines 1722 1792 +70
Branches 168 182 +14
==========================================
+ Hits 1615 1621 +6
- Misses 90 154 +64
Partials 17 17 |
|
Any way moving this back to evmc? |
That would be very inconvenient for developing evmone as you don't want to have unit tests in other project. |
|
The name is misleading then, should be |
It tests EVMs. |
|
So it is not evmone specific then? |
Description updated. |
|
So then my question is reasonable: any possibility moving this out of evmone at some point to aid other VMs using evmc? |
The answer is still no. The I'm going to get the reference to this tool from ethereum/testing. |
|
So it is basically a "state test over evmc" tool. Still, it would make sense to have it outside of evmone to encourage other EVMC compatible EVMs to use it. Not saying it has to be in evmc, since it may not belong there. |
Yes it make sense for other projects but not for this project. And is not worth the trouble and my time at this point. |
chfast
requested review from
axic,
cdetrio,
gumb0,
halfalicious,
holiman and
winsvega
| @@ -43,6 +43,18 @@ bin/evmone-unittests | |||
| bin/evmone-bench | |||
| ``` | |||
|
|
|||
| ### Tools | |||
|
|
|||
| #### evm-test | |||
There was a problem hiding this comment.
At the bare minimum extending this section on build instruction if it is possible to only build this without evmone to be used by other projects would be useful.
There was a problem hiding this comment.
This is not possible right now. I need another round of CMake changes to re-tune build options.
| {"MODULE"}}; | ||
| cli.set_preprocessor(testing::InitGoogleTest); | ||
|
|
||
| if (const auto error_code = cli.parse(argc, argv, std::cout, std::cerr); error_code <= 0) |
|
|
||
| if (ec != EVMC_LOADER_SUCCESS) | ||
| { | ||
| if (const auto error = evmc_last_error_msg()) |
There was a problem hiding this comment.
This could be just
const auto error = evmc_last_error_msg();
std::cerr << "EVMC loading error: " << (error ? error : ec) << "\n";
| #include <vector> | ||
|
|
||
| /// The loaded EVMC module. | ||
| static evmc::vm evmc_module; |
There was a problem hiding this comment.
It would be less confusing if this and get_evm below were in a separate cpp file, then it would be more clear that it's another implementation for get_evm of vm_loader.hpp
(some setter I guess would be required then, too)
There was a problem hiding this comment.
It was planned like that, but it gets tricky because evmc_module is set from main().
| @@ -0,0 +1,179 @@ | |||
| // evmone: Fast Ethereum Virtual Machine implementation | |||
There was a problem hiding this comment.
It would probably be better if this file were in a separate directory, not unittests?
There was a problem hiding this comment.
There are more changes to dir structure needed, so I left it for another time.
Preferably the evm-test should be in tools/, not in test/ but because the evm-unitests is shared between evm-test and evmone-unittests it might be overkill.
Maybe just get rid of test/ dir entirely...
This adds EVM testing tool for EVMC-compatible VM implementations.
It is build out of generic evmone execution tests.
E.g.
Do not confuse with evmone-unittests which contains these test + internal unit tests and has evmone linked "statically".
The name
evmone-testwas also considered.TODO: