Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication for engine api #167

Merged
merged 6 commits into from
Feb 8, 2022
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions src/engine/authentication.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# Authentication

The `engine` JSON-RPC interface, exposed by EL and consumed by CL, needs to be authenticated. The authentication scheme chosen for thus purpose is [JWT](https://jwt.io/).

The type of attacks that this authentication scheme attempts to protect against are the following:

- RPC port exposed towards the internet, allowing attackers to exchange messages with EL engine api.
- RPC port exposed towards the browser, allowing malicious webpages to submit messages to the EL engine api.

The authentication scheme is _not_ designed to

- Prevent attackers with capability to read ('sniff') network traffic from reading the traffic,
- Prevent attackers with capability to read ('sniff') network traffic from performing replay-attacks of earlier messages.
djrtwo marked this conversation as resolved.
Show resolved Hide resolved

Authentication is performed as follows:

- For `HTTP` dialogue, each `jsonrpc` request is individually authenticated by supplying `JWT` token in the HTTP header.
- For a WebSocket dialogue, only the initial handshake is authenticated, after which the message dialogue proceeds without further use of JWT.
- Clarification: The websocket handshake starts with the client performing a websocket upgrade request. This is a regular http GET request, and the actual
parameters for the WS-handshake are carried in the http headers.
- For `inproc`, a.k.a raw ipc communication, no authentication is required, under the assumption that a process able to access `ipc` channels for the process, which usually means local file access, is already sufficiently permissioned that further authentication requirements do not add security.


## JWT specifications

- Client software MUST expose the authenticated Engine API at a port independent from legacy JSON-RPC API.
djrtwo marked this conversation as resolved.
Show resolved Hide resolved
- The default port for the authenticated Engine API is `8551`. The Engine API is exposed under the `engine` namespace.
- On the authenticated endpoint, the legacy API **MUST** also be available.
djrtwo marked this conversation as resolved.
Show resolved Hide resolved
- The EL **MUST** support at least the following `alg` `HMAC + SHA256` (`HS256`)
- The EL **MUST** reject the `alg` `none`.


The HMAC algorithm means that symmetric encryption is used, thus several CL's will be able to use the same key, and, from an authentication perspective be able to impersonate each other. From a deployment perspective, it means that an EL does not need to be provisioned with individual keys for each caller.

## Key distribution

The `EL` and `CL` clients **MUST** accept a cli/config parameter: `jwt-secret`, a `256` bit key, to be used for verifying/generating jwt tokens.
If such a parameter is not given, the client **SHOULD** generate such a token, valid for the duration of the execution, and show the token in the output, which the user can then use to provision the counterpart client with.
djrtwo marked this conversation as resolved.
Show resolved Hide resolved

## JWT Claims

The JWT payload/claims should include:
djrtwo marked this conversation as resolved.
Show resolved Hide resolved
djrtwo marked this conversation as resolved.
Show resolved Hide resolved

- Required: `iat` (issued-at) claim. The EL **SHOULD** only accept `iat` timestamps which are within +-5 seconds from the current time.
- Optional: `id` claim. The CL **MAY** use this to communicate a unique identifier for the individual CL node.
- Optional: `clv` claim. The CL **MAY** use this to communicate the CL node type/version.

Other claims included in the JWT payload, which the EL does not handle, **MUST** be ignored.
djrtwo marked this conversation as resolved.
Show resolved Hide resolved

## Examples

Todo, add some examples of JWT authentication here.