Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci,evm_transition_tool): Add EthereumJS #752

Merged
merged 10 commits into from
Sep 13, 2024

Conversation

jochem-brouwer
Copy link
Member

This PR adds an EthereumJS wrapper, which can be used to fill tests. Needs: ethereumjs/ethereumjs-monorepo#3603

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we could merge now, and the only remaining thing before releasing would be the 2935 issue because it affects all Prague tests, even the ones unrelated to EIP-2935.

.github/actions/build-evm-client/ethjs/action.yml Outdated Show resolved Hide resolved
.github/configs/feature.yaml Outdated Show resolved Hide resolved
@marioevz marioevz changed the title Add EthereumJS wrapper feat(github,evm_transition_tool): Add EthereumJS Aug 20, 2024
@danceratopz danceratopz changed the title feat(github,evm_transition_tool): Add EthereumJS feat(ci,evm_transition_tool): Add EthereumJS Sep 3, 2024
@danceratopz danceratopz added scope:ci Scope: Continuous Integration type:feat type: Feature labels Sep 3, 2024
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just updated docs to reflect the addition (we should double check the links when ethereumjs/ethereumjs-monorepo#3603 is merged).

@jochem-brouwer jochem-brouwer marked this pull request as ready for review September 13, 2024 14:05
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 589ab4e into ethereum:main Sep 13, 2024
4 checks passed
@jochem-brouwer
Copy link
Member Author

Also got t8n merged on our side ethereumjs/ethereumjs-monorepo#3603, so we are now ready-to go to fill some tests 😄 🚀

@jochem-brouwer jochem-brouwer deleted the ethereumjs-wrapper branch September 14, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants