-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci,evm_transition_tool): Add EthereumJS #752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we could merge now, and the only remaining thing before releasing would be the 2935 issue because it affects all Prague tests, even the ones unrelated to EIP-2935.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just updated docs to reflect the addition (we should double check the links when ethereumjs/ethereumjs-monorepo#3603 is merged).
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
…ion-spec-tests into ethereumjs-wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Also got t8n merged on our side ethereumjs/ethereumjs-monorepo#3603, so we are now ready-to go to fill some tests 😄 🚀 |
This PR adds an EthereumJS wrapper, which can be used to fill tests. Needs: ethereumjs/ethereumjs-monorepo#3603