new(tests): TSTORE: ensure transient storage is cleared after transactions #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochem-brouwer
changed the title
jochem-brouwer
force-pushed
the
tstore_clear_storage_between_txs
branch
from
f44bf6a
to
2da3856
Compare
marioevz
reviewed
Sep 13, 2024
jochem-brouwer
force-pushed
the
tstore_clear_storage_between_txs
branch
from
12ca3d3
to
7447330
Compare
holgerd77
reviewed
Sep 17, 2024
holgerd77
reviewed
Sep 17, 2024
…rage_between_txs/mypy-tweaks chore: fix mypy tox errors
jochem-brouwer
force-pushed
the
tstore_clear_storage_between_txs
branch
from
af9c7df
to
48e070a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR introduces 2 tests, which test that the transient storage is cleared after transactions. EthereumJS did clear storage after "normal" transactions, but did not clear the transient storage after a transaction created a contract. If the deployed contract address was then called, then the transient storage was not empty. See: ethereumjs/ethereumjs-monorepo#3625. This was not caught by these tests, so I have added two tests, one which does the create-tx and then call-contract, and the other calls the same contract twice.
The tests are very repetitive, so I would love some suggestions how to make those more compact (we could also move these two tests into one single test, where we use 3 transactions instead of two, writing to different storage slots and different transient storage slots).
The good/bad cases of these tests have been tested using EthereumJS (with and without the bug) using our new t8ntool 😄
🔗 Related Issues
Test produced by a bug in EthereumJS: ethereumjs/ethereumjs-monorepo#3625
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.