Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forks,tests): Osaka #869

Merged
merged 16 commits into from
Oct 8, 2024
Merged

feat(forks,tests): Osaka #869

merged 16 commits into from
Oct 8, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Oct 2, 2024

🗒️ Description

  • All references to PragueEIP7692 have been renamed to Osaka, including the fork class
  • CancunEIP7692 still exists but a comment has been added to signal deprecation
  • tests/prague/eip7692_eof_v1 has been moved to tests/osaka and references have been updated

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:forks Scope: ethereum_test_forks package scope:tests Scope: Test cases scope:docs Scope: Documentation scope:ci Scope: Continuous Integration type:refactor Type: Refactor type:feat type: Feature labels Oct 2, 2024
tests/osaka/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Few minor suggestions and a question.

src/pytest_plugins/filler/gen_test_doc/page_props.py Outdated Show resolved Hide resolved
src/pytest_plugins/filler/gen_test_doc/gen_test_doc.py Outdated Show resolved Hide resolved
src/ethereum_test_forks/forks/forks.py Outdated Show resolved Hide resolved
src/ethereum_test_forks/forks/forks.py Outdated Show resolved Hide resolved
tests/osaka/eip7692_eof_v1/eof_tracker.md Outdated Show resolved Hide resolved
@marioevz marioevz merged commit b69e696 into main Oct 8, 2024
5 checks passed
@marioevz marioevz deleted the osaka branch October 8, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration scope:docs Scope: Documentation scope:forks Scope: ethereum_test_forks package scope:tests Scope: Test cases type:feat type: Feature type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants