Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FloorDiv #341

Closed
g-r-a-n-t opened this issue Mar 26, 2021 · 0 comments
Closed

Remove FloorDiv #341

g-r-a-n-t opened this issue Mar 26, 2021 · 0 comments
Labels
comp: parser good first issue Good for newcomers type: chore

Comments

@g-r-a-n-t
Copy link
Member

I don't think we need //. My understanding is that Python provides this because it only provides one numeric base type and via / and // it lets you switch between floating point division and integer division. We currently only have integer division and if we ever add another base type to represent numbers with a decimal point then one would be free to use that datatype to perform such a division operations. So it is the chosen base type that would decide about it, not the operator.

Originally posted by @cburgdorf in #338 (comment)
@g-r-a-n-t g-r-a-n-t mentioned this issue Mar 29, 2021
Merged
3 tasks
@sbillig sbillig added the good first issue Good for newcomers label Apr 23, 2021
sbillig added a commit to sbillig/fe that referenced this issue May 7, 2021
@sbillig
ast: remove FloorDiv
0e31d9e 
closes ethereum#341
@sbillig sbillig mentioned this issue May 7, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: parser good first issue Good for newcomers type: chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbillig @g-r-a-n-t