Mapper module reorg / ABI pack and unpack #172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
1.) See #129
2.) The code responsible for adding non-user defined functions needed during runtime was a bit scattered.
How was it fixed?
1.) Added runtime functions for packing and unpacking arrays and used them in our dynamically generated encoding/decoding functions.
2.) Added a module named
runtime
to the compiler that is used to build a vector of functions needed during runtime. This better consolidates some pieces of code that had been scattered. It should make runtime-building quite a bit easier in the future. This module exposes a simple API:runtime::build(context, contract)
andruntime::build_with_abi_dispatcher(context, contract)
.To-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history