Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encoding/decoding nested struct types #729

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

Y-Nak
Copy link
Member

@Y-Nak Y-Nak commented Jun 1, 2022

What was wrong?

close #635, close #733

How was it fixed?

Implement encoding/decoding runtime functions for nested struct types.

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@Y-Nak Y-Nak mentioned this pull request Jun 1, 2022
7 tasks
@Y-Nak Y-Nak changed the title Implement encoding for nested struct types Support returning complex struct Jun 1, 2022
@Y-Nak Y-Nak changed the title Support returning complex struct Support encoding/decoding nested struct types Jun 3, 2022
@Y-Nak Y-Nak force-pushed the recursive-encoding branch from e1ea468 to 6033090 Compare June 3, 2022 14:03
@Y-Nak Y-Nak requested a review from cburgdorf June 3, 2022 14:03
@Y-Nak Y-Nak force-pushed the recursive-encoding branch from 6033090 to 2dc452d Compare June 3, 2022 14:07
@Y-Nak Y-Nak marked this pull request as ready for review June 3, 2022 14:07
Copy link
Collaborator

@cburgdorf cburgdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot stuff 🔥
LGTM

@Y-Nak Y-Nak merged commit 6a7c648 into ethereum:master Jun 6, 2022
@Y-Nak Y-Nak deleted the recursive-encoding branch June 6, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants