Skip to content

Commit

Permalink
miner: send full request when resolving full payload (#30615)
Browse files Browse the repository at this point in the history
Fixes an issue missed in #30576 where we send empty requests for a full
payload being resolved, causing hash mismatch later on when we get the
payload back via `NewPayload`.
  • Loading branch information
lightclient authored and holiman committed Nov 19, 2024
1 parent e648904 commit 5d41ac5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion miner/payload_building.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func (payload *Payload) Resolve() *engine.ExecutionPayloadEnvelope {
close(payload.stop)
}
if payload.full != nil {
envelope := engine.BlockToExecutableData(payload.full, payload.fullFees, payload.sidecars, payload.emptyRequests)
envelope := engine.BlockToExecutableData(payload.full, payload.fullFees, payload.sidecars, payload.requests)
if payload.fullWitness != nil {
envelope.Witness = new(hexutil.Bytes)
*envelope.Witness, _ = rlp.EncodeToBytes(payload.fullWitness) // cannot fail
Expand Down

0 comments on commit 5d41ac5

Please sign in to comment.