eth/catalyst: when forgetting bad hashes, also forget descendants

ethereum · Jul 25, 2022 · 7d94ebf · 7d94ebf
1 parent 001a93f
commit 7d94ebf
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/eth/catalyst/api.go b/eth/catalyst/api.go
@@ -447,6 +447,12 @@ func (api *ConsensusAPI) checkInvalidAncestor(check common.Hash, head common.Has
 	if api.invalidBlocksHits[badHash] >= invalidBlockHitEviction {
 		log.Warn("Too many bad block import attempt, trying", "number", invalid.Number, "hash", badHash)
 		delete(api.invalidBlocksHits, badHash)
+
+		for descendant, badHeader := range api.invalidTipsets {
+			if badHeader.Hash() == badHash {
+				delete(api.invalidTipsets, descendant)
+			}
+		}
 		return nil
 	}
 	// Not too many failures yet, mark the head of the invalid chain as invalid