Can not apply transactions with incremented nonce when NoPrefetch=false

[ramilexe]

When I was working on PR #19721 found a bug with NoPrefetch parameter in config:

Without NoPrefetch: true (line 188)

go-ethereum/ethclient/ethclient_test.go

Lines 187 to 192 in cc479b8

	n.Register(func(ctx *node.ServiceContext) (node.Service, error) {
	config := &eth.Config{Genesis: genesis, NoPrefetch: true}
	config.Ethash.PowMode = ethash.ModeFake
	ethservice, err = eth.New(ctx, config)
	return ethservice, err
	})

When I try to add 2 consecutive transactions with nonce 0 and 1 (line 240 and 247):

go-ethereum/ethclient/ethclient_test.go

Lines 234 to 254 in cc479b8

	generate := func(i int, g *core.BlockGen) {
	g.OffsetTime(5)
	g.SetExtra([]byte("test"))
	switch i {
	case 0:
	tx, err := types.SignTx(types.NewTransaction(g.TxNonce(testAddr), common.HexToAddress("0x1"), big.NewInt(1), 21000, big.NewInt(1), nil), signer, testKey)
	if err != nil {
	t.Fatal(err)
	}
	g.AddTx(tx)
	case 1:
	tx, err := types.SignTx(types.NewTransaction(g.TxNonce(testAddr), common.HexToAddress("0x2"), big.NewInt(2), 21000, big.NewInt(1), nil), signer, testKey)
	if err != nil {
	t.Fatal(err)
	}
	g.AddTx(tx)
	}
	}

I get error nonce too high on line 172:

go-ethereum/core/state_transition.go

Lines 167 to 178 in cc479b8

	func (st *StateTransition) preCheck() error {
	// Make sure this transaction's nonce is correct.
	if st.msg.CheckNonce() {
	nonce := st.state.GetNonce(st.msg.From())
	if nonce < st.msg.Nonce() {
	return ErrNonceTooHigh
	} else if nonce > st.msg.Nonce() {
	return ErrNonceTooLow
	}
	}
	return st.buyGas()
	}

I think it related to #19328

/cc @karalabe @holiman

[holiman]

I guess it doesn't make sense to have prefetch=true on tests that do not actually process blocks properly, but it would be good to have @karalabe check that there isn't some deeper issue here.

[karalabe]

This is an odd one. Prefetching should run the next block in advance, which in this case will genuinely fail... but that failure should never bubble up outside, since we're only doing it to pre-load data, we don't actually keep the execution result.

@ramilexe Do you actually hit an error, or are you just pondering about what's happening under the hood?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.