RPC API: get receipts by block number #19721
Conversation
tests: - eth_getTransactionByBlockHashAndIndex - eth_getBlockReceipts
|
|
||
| // Start Ethereum service. | ||
| var ethservice *eth.Ethereum | ||
| n, err := node.New(&node.Config{}) | ||
| n.Register(func(ctx *node.ServiceContext) (node.Service, error) { | ||
| config := ð.Config{Genesis: genesis} | ||
| config := ð.Config{Genesis: genesis, NoPrefetch: true} |
There was a problem hiding this comment.
without this parameter it produces nonce too high error. For details see #19723
|
any process to update RPC document? @adamschmideg :) |
|
@hadv No update to the RPC document yet 🤷♂ |
|
What does status triage mean? |
|
@ramilexe the |
|
I left a comment to #19634 describing how to get gasUsed with GraphQL. I wonder if that approach works for you. Because changing the RPC comprises of two tasks, a) to change the code which you already did b) write and EIP and change the standard interface. Do you think adding |
| // BlockReceipts returns the receipts of a transaction by block number. | ||
| func (ec *Client) BlockReceipts(ctx context.Context, number *big.Int) (types.Receipts, error) { | ||
| var result types.Receipts | ||
| err := ec.c.CallContext(ctx, &result, "eth_getBlockReceipts", toBlockNumArg(number)) |
There was a problem hiding this comment.
It seems that both web3ext.go and web3.js need to be modified to bind "eth_getBlockReceipts" and "GetBlockReceipts", and expose "eth_getBlockReceipts".
| result := make([]map[string]interface{}, 0, len(receipts)) | ||
|
|
||
| for index, receipt := range receipts { | ||
| tx := txs[index] |
There was a problem hiding this comment.
Directly using index of receipts to look for corresponding tx is not so rigorous. Suggest to modify it to:
tx := txs[receipt.TransactionIndex]
|
|
||
| result := make([]map[string]interface{}, 0, len(receipts)) | ||
|
|
||
| for index, receipt := range receipts { |
There was a problem hiding this comment.
receipt.TransactionIndex could stand for index, so index here makes no sense. Suggest to replace it with blank identifier "_"
| "blockHash": block.Hash(), | ||
| "blockNumber": hexutil.Uint64(blockNr), | ||
| "transactionHash": receipt.TxHash, | ||
| "transactionIndex": hexutil.Uint64(index), |
There was a problem hiding this comment.
Suggest to replace index with receipt.TransactionIndex
|
We had a bit of an internal discussion around this. The new method is very useful and provides a much faster way of getting block receipts than the current way, which would be to retrieve them individually by transaction hash. Since this change adds new API surface to the The PR can remain open, but will not be merged until the EIP has been created. |
|
Hi @fjl |
|
@ramilexe Hello, have you created EIP for |
|
This PR is now < 2 years old, will likely not get merged (afaik there was never any EIP created for this). I'll close it, we can always reimplement this if we want the method to exist. |
@holiman I would be happy to do the work to get this feature added. Assuming the correct steps are taken, do you think it could be added? |
For issue #19634
Added new RPC API:
eth_getBlockReceipts. It returns receipts by block number.Also, implemented tests for: