Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_getWork RPC call is missing block number of seed hash #2333

Closed
jameshilliard opened this issue Mar 14, 2016 · 6 comments
Closed

eth_getWork RPC call is missing block number of seed hash #2333

jameshilliard opened this issue Mar 14, 2016 · 6 comments
Assignees

Comments

@jameshilliard
Copy link

The eth_getWork rpc call appears to be missing the block number of the seed hash needed to compute a DAG for mining. From reading the documentation I need two parameters to generate a DAG, a seed hash and the corresponding block number of that seed hash. Based on that the only way to generate a DAG is to make a separate RPC call such as an eth_blocknumber call and then use that to infer the block number of the seed hash, but that doesn't seem to be the right way to do this.

@fjl fjl modified the milestone: 1.4.0 Mar 14, 2016
@fjl fjl self-assigned this Mar 14, 2016
@sammy007
Copy link
Contributor

If you are going to add block number as additional parameter for getWork response, please append in to array, not prepend for backward compatibility. Also would be cool to also get both number and difficulty from getBlockByNumber as part of getWork. Currently there is no way to get consistent result with 2 rpc calls.

@peterbitfly
Copy link
Contributor

I don't think the block number is required at all. You can infer the epoch for the dag from the seed hash itself, that's also how ethminer does it

@sammy007
Copy link
Contributor

Epoch is epoch, I need a block number for logging.

@Visgean
Copy link

Visgean commented Aug 26, 2016

@Visgean
Copy link

Visgean commented Aug 29, 2016

Another reason for implementing this feature is that Parity already has a 4th parameter. See https://github.com/ethcore/parity/wiki/JSONRPC-eth-module#eth_getwork

@stale
Copy link

stale bot commented Mar 5, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:inactive label Mar 5, 2018
@stale stale bot closed this as completed Apr 16, 2018
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants